Add support for announcing and querying LBRY streams over BEP15 (BitTorrent Trackers) #3576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shyba
force-pushed
the
trackers
branch
5 times, most recently
from
eb0d481
to
d767d22
Compare
eukreign
requested changes
May 4, 2022
lbry/extras/daemon/components.py
Outdated
|
|
||
| async def announce_forever(self): | ||
| while True: | ||
| to_sleep = 60.0 |
There was a problem hiding this comment.
better name might be sleep_time or sleep_seconds
lbry/extras/daemon/components.py
Outdated
| async def announce_forever(self): | ||
| while True: | ||
| to_sleep = 60.0 | ||
| to_announce = [] |
There was a problem hiding this comment.
better name might be announce_sd_hashes or sd_hashes_to_announce (i prefer announce_sd_hashes)
lbry/torrent/tracker.py
Outdated
|
|
||
| def decode(cls, data, offset=0): | ||
| decoder = STRUCTS[cls] | ||
| if cls == AnnounceResponse: |
There was a problem hiding this comment.
should all of the if branches be is instead of a == operator?
lbry/torrent/tracker.py
Outdated
|
|
||
|
|
||
| class TrackerClient: | ||
| EVENT_CONTROLLER = StreamController() |
There was a problem hiding this comment.
in Python only true constants are generally all caps, in this case EVENT_CONTROLLER is not a constant but a mutating object. should just be underscore case
lbry/torrent/tracker.py
Outdated
| ScrapeResponse = namedtuple("ScrapeResponse", ["action", "transaction_id", "items"]) | ||
| ScrapeResponseItem = namedtuple("ScrapeResponseItem", ["seeders", "completed", "leechers"]) | ||
| ErrorResponse = namedtuple("ErrorResponse", ["action", "transaction_id", "message"]) | ||
| STRUCTS = { |
There was a problem hiding this comment.
should be camel case or just lower case?
according to python style guide, global variable names should follow function naming scheme:
https://peps.python.org/pep-0008/#global-variable-names
…tests more reliable
…uncement abstraction
eukreign
approved these changes
May 13, 2022
eukreign
added
type: new feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small guide on how to run a tracker (should live elsewhere when ready): https://hackmd.io/@CoIkpN7DQWa6tkftkqccWA/HyxN-Z_m9