Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new wallet commands for importing and exporting wallets #3637

Merged
merged 8 commits into from
Aug 1, 2022

Conversation

jessopb
Copy link
Member

@jessopb jessopb commented Jul 22, 2022

@eukreign Recommended a wallet import / output method rather than altering the behavior of sync apply. This does not force reset the wallet encrypt password with the import/export data encrypt password.

I mostly duplilcated what I thought was the relevant sync_apply test. Let me know if you think any of the test is too redundant or missing.

@jessopb jessopb requested a review from eukreign July 22, 2022 13:43
@lbry-bot lbry-bot assigned eukreign and unassigned jessopb Jul 22, 2022
@coveralls
Copy link

Coverage Status

Coverage remained the same at 57.383% when pulling 50e6cf3 on feature-walletImportExport into ba60aee on master.

Copy link
Member

@eukreign eukreign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this PR ready for one final review?

lbry/extras/daemon/daemon.py Outdated Show resolved Hide resolved
@lbry-bot lbry-bot assigned jessopb and unassigned eukreign Jul 25, 2022
@jessopb
Copy link
Member Author

jessopb commented Aug 1, 2022

Review?

Yes please

@jessopb jessopb requested a review from eukreign August 1, 2022 12:40
@lbry-bot lbry-bot assigned eukreign and unassigned jessopb Aug 1, 2022
@lbry-bot lbry-bot assigned jessopb and unassigned eukreign Aug 1, 2022
@eukreign eukreign added type: new feature New functionality that does not exist yet area: api labels Aug 1, 2022
@eukreign eukreign changed the title wallet import export feature new wallet commands for importing and exporting wallets Aug 1, 2022
@eukreign eukreign merged commit 1dc2f04 into master Aug 1, 2022
@eukreign eukreign deleted the feature-walletImportExport branch August 1, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: api type: new feature New functionality that does not exist yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants