-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new wallet
commands for import
ing and export
ing wallets
#3637
Merged
+126
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eukreign
requested changes
Jul 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this PR ready for one final review?
Yes please |
eukreign
force-pushed
the
feature-walletImportExport
branch
from
August 1, 2022 13:42
5ef78d9
to
fa3ea2c
Compare
eukreign
approved these changes
Aug 1, 2022
eukreign
added
type: new feature
New functionality that does not exist yet
area: api
labels
Aug 1, 2022
eukreign
changed the title
wallet import export feature
new Aug 1, 2022
wallet
commands for import
ing and export
ing wallets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@eukreign Recommended a wallet import / output method rather than altering the behavior of sync apply. This does not force reset the wallet encrypt password with the import/export data encrypt password.
I mostly duplilcated what I thought was the relevant sync_apply test. Let me know if you think any of the test is too redundant or missing.