Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gui] max-width compute result are incorrect #113

Closed
lc-soft opened this issue Nov 17, 2017 · 2 comments
Closed

[gui] max-width compute result are incorrect #113

lc-soft opened this issue Nov 17, 2017 · 2 comments
Assignees
Labels
Milestone

Comments

@lc-soft
Copy link
Owner

lc-soft commented Nov 17, 2017

Expected result:

image

Actual result:

image

image

image

@lc-soft lc-soft added the bug label Nov 17, 2017
@lc-soft lc-soft added this to the 1.0.0 beta 1 milestone Nov 17, 2017
@lc-soft lc-soft self-assigned this Nov 17, 2017
@lc-soft
Copy link
Owner Author

lc-soft commented Nov 18, 2017

Here has a stylesheet selection bug from src/gui/css_library.c#L1104

Example:

.col-6 {
  display: inline-block;
  max-width: 100%;
}
 .col {
  width: 100%;
  max-width: 100%;
}
.col-6 {
  max-width: 50%;
}

The effect of the above code is equivalent to the following code:

.col-6 {
  display: inline-block;
  max-width: 50%;
}
 .col {
  width: 100%;
  max-width: 100%;
}

The two stylesheets will be merged into a single styleesheet.

lc-soft added a commit that referenced this issue Nov 18, 2017
@lc-soft
Copy link
Owner Author

lc-soft commented Nov 18, 2017

Done.

image

@lc-soft lc-soft closed this as completed Nov 18, 2017
@lc-soft lc-soft mentioned this issue Jan 31, 2018
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant