修复ConvertFromUtf16BEBytesToUtf8BOMBytes方法 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lc6464
requested changes
Sep 13, 2023
| var temp = Encoding.Convert(Encoding.BigEndianUnicode, new UTF8Encoding(), data.ToArray()); | ||
| var bom = new byte[]{ 0xEF, 0xBB, 0xBF }; | ||
| var result = bom.Concat(temp).ToArray(); | ||
| return new ReadOnlySpan<byte>(result); |
There was a problem hiding this comment.
我觉得 L25 和 L26 肯定可以优化，另外就是这个 BOM 应该提取出来。
|
DeepSource Transformers 没权限啊 @execute233 |
|
放弃这个 PR 了。 |
|
6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
用一种简单粗暴的方式让它带上BOM了