Skip to content

Commit

Permalink
Remove old team member aliases throughout codebase (GoogleCloudPlatfo…
Browse files Browse the repository at this point in the history
  • Loading branch information
rileykarson authored and lcaggio committed Mar 16, 2022
1 parent 7bde5d2 commit 772cad9
Show file tree
Hide file tree
Showing 10 changed files with 19 additions and 19 deletions.
2 changes: 1 addition & 1 deletion .ci/containers/contributor-checker/check-contributor.sh
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ USER=$(curl -H "Authorization: token ${GITHUB_TOKEN}" \

# This is where you add users who do not need to have an assignee chosen for
# them.
if $(echo $USER | fgrep -wq -e ndmckinley -e danawillow -e megan07 -e paddycarver -e rambleraptor -e SirGitsalot -e slevenick -e c2thorn -e rileykarson -e melinath -e ScottSuarez -e shuyama1); then
if $(echo $USER | fgrep -wq -e megan07 -e rambleraptor -e SirGitsalot -e slevenick -e c2thorn -e rileykarson -e melinath -e ScottSuarez -e shuyama1); then
echo "User is on the list, not assigning."
exit 0
fi
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ USER=$(curl -H "Authorization: token ${GITHUB_TOKEN}" \

# This image runs tests for community PRs. This script reverses check_membership.sh to exit without running tests
# for users for who tests are automatically run.
if $(echo $USER | fgrep -wq -e ndmckinley -e danawillow -e emilymye -e megan07 -e paddycarver -e rambleraptor -e SirGitsalot -e slevenick -e c2thorn -e rileykarson -e melinath -e ScottSuarez -e shuyama1 -e trodge); then
if $(echo $USER | fgrep -wq -e megan07 -e rambleraptor -e SirGitsalot -e slevenick -e c2thorn -e rileykarson -e melinath -e ScottSuarez -e shuyama1 -e trodge); then
echo "User is on the list, skipping."
exit 0
else
Expand Down
2 changes: 1 addition & 1 deletion .ci/containers/terraform-vcr-tester/check_membership.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ USER=$(curl -H "Authorization: token ${GITHUB_TOKEN}" \
"https://api.github.com/repos/GoogleCloudPlatform/magic-modules/issues/${pr_number}" | jq -r .user.login)

# Only run tests for safe users
if $(echo $USER | fgrep -wq -e ndmckinley -e danawillow -e emilymye -e megan07 -e paddycarver -e rambleraptor -e SirGitsalot -e slevenick -e c2thorn -e rileykarson -e melinath -e ScottSuarez -e shuyama1 -e trodge); then
if $(echo $USER | fgrep -wq -e megan07 -e rambleraptor -e SirGitsalot -e slevenick -e c2thorn -e rileykarson -e melinath -e ScottSuarez -e shuyama1 -e trodge); then
echo "User is on the list, not skipping."
else
echo "Checking GCP org membership"
Expand Down
2 changes: 1 addition & 1 deletion mmv1/products/compute/api.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13123,7 +13123,7 @@ objects:
A reference to the network to which this router belongs.
required: true
input: true
# TODO(danawillow): Figure out the story for interfaces/bgpPeers. Right
# TODO: Figure out the story for interfaces/bgpPeers. Right
# now in Terraform we have three separate resources: router,
# router_interface, and router_peer. Decide whether we want to keep that
# pattern for the other providers, keep it unique for Terraform, or add
Expand Down
2 changes: 1 addition & 1 deletion mmv1/products/datacatalog/api.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ objects:
description: |
Map of tag template field IDs to the settings for the field. This map is an exhaustive list of the allowed fields. This map must contain at least one field and at most 500 fields.
required: true
input: true # TODO(danawillow): update logic
input: true # TODO: update logic
key_name: field_id
value_type: !ruby/object:Api::Type::NestedObject
name: field
Expand Down
2 changes: 1 addition & 1 deletion mmv1/products/datastore/terraform.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ overrides: !ruby/object:Overrides::ResourceOverrides
self_link: "projects/{{project}}/indexes/{{index_id}}"
error_retry_predicates: ["datastoreIndex409Contention"]
autogen_async: true
# TODO(ndmckinley): This resource doesn't have a name, so the current
# TODO: This resource doesn't have a name, so the current
# sweeper won't ever sweep it - might as well not have one for now,
# but we'll add it in when we change the sweeper to account for
# identity.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -875,7 +875,7 @@ func resourceContainerCluster() *schema.Resource {
Type: schema.TypeList,
Optional: true,
Computed: true,
ForceNew: true, // TODO(danawillow): Add ability to add/remove nodePools
ForceNew: true, // TODO: Add ability to add/remove nodePools
Elem: &schema.Resource{
Schema: schemaNodePool,
},
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ func TestAccComposerEnvironment_basic(t *testing.T) {
},
// This is a terrible clean-up step in order to get destroy to succeed,
// due to dangling firewall rules left by the Composer Environment blocking network deletion.
// TODO(emilyye): Remove this check if firewall rules bug gets fixed by Composer.
// TODO: Remove this check if firewall rules bug gets fixed by Composer.
{
PlanOnly: true,
ExpectNonEmptyPlan: false,
Expand Down Expand Up @@ -122,7 +122,7 @@ func TestAccComposerEnvironment_update(t *testing.T) {
},
// This is a terrible clean-up step in order to get destroy to succeed,
// due to dangling firewall rules left by the Composer Environment blocking network deletion.
// TODO(emilyye): Remove this check if firewall rules bug gets fixed by Composer.
// TODO: Remove this check if firewall rules bug gets fixed by Composer.
{
PlanOnly: true,
ExpectNonEmptyPlan: false,
Expand Down Expand Up @@ -162,7 +162,7 @@ func TestAccComposerEnvironment_private(t *testing.T) {
},
// This is a terrible clean-up step in order to get destroy to succeed,
// due to dangling firewall rules left by the Composer Environment blocking network deletion.
// TODO(emilyye): Remove this check if firewall rules bug gets fixed by Composer.
// TODO: Remove this check if firewall rules bug gets fixed by Composer.
{
PlanOnly: true,
ExpectNonEmptyPlan: false,
Expand Down Expand Up @@ -210,7 +210,7 @@ func TestAccComposerEnvironment_privateWithWebServerControl(t *testing.T) {
},
// This is a terrible clean-up step in order to get destroy to succeed,
// due to dangling firewall rules left by the Composer Environment blocking network deletion.
// TODO(emilyye): Remove this check if firewall rules bug gets fixed by Composer.
// TODO: Remove this check if firewall rules bug gets fixed by Composer.
{
PlanOnly: true,
ExpectNonEmptyPlan: false,
Expand Down Expand Up @@ -245,7 +245,7 @@ func TestAccComposerEnvironment_withDatabaseConfig(t *testing.T) {
},
// This is a terrible clean-up step in order to get destroy to succeed,
// due to dangling firewall rules left by the Composer Environment blocking network deletion.
// TODO(emilyye): Remove this check if firewall rules bug gets fixed by Composer.
// TODO: Remove this check if firewall rules bug gets fixed by Composer.
{
PlanOnly: true,
ExpectNonEmptyPlan: false,
Expand Down Expand Up @@ -280,7 +280,7 @@ func TestAccComposerEnvironment_withWebServerConfig(t *testing.T) {
},
// This is a terrible clean-up step in order to get destroy to succeed,
// due to dangling firewall rules left by the Composer Environment blocking network deletion.
// TODO(emilyye): Remove this check if firewall rules bug gets fixed by Composer.
// TODO: Remove this check if firewall rules bug gets fixed by Composer.
{
PlanOnly: true,
ExpectNonEmptyPlan: false,
Expand Down Expand Up @@ -624,7 +624,7 @@ func TestAccComposerEnvironment_withNodeConfig(t *testing.T) {
},
// This is a terrible clean-up step in order to get destroy to succeed,
// due to dangling firewall rules left by the Composer Environment blocking network deletion.
// TODO(emilyye): Remove this check if firewall rules bug gets fixed by Composer.
// TODO: Remove this check if firewall rules bug gets fixed by Composer.
{
PlanOnly: true,
ExpectNonEmptyPlan: false,
Expand Down Expand Up @@ -656,7 +656,7 @@ func TestAccComposerEnvironment_withSoftwareConfig(t *testing.T) {
},
// This is a terrible clean-up step in order to get destroy to succeed,
// due to dangling firewall rules left by the Composer Environment blocking network deletion.
// TODO(emilyye): Remove this check if firewall rules bug gets fixed by Composer.
// TODO: Remove this check if firewall rules bug gets fixed by Composer.
{
PlanOnly: true,
ExpectNonEmptyPlan: false,
Expand Down Expand Up @@ -688,7 +688,7 @@ func TestAccComposerEnvironmentAirflow2_withSoftwareConfig(t *testing.T) {
},
// This is a terrible clean-up step in order to get destroy to succeed,
// due to dangling firewall rules left by the Composer Environment blocking network deletion.
// TODO(emilyye): Remove this check if firewall rules bug gets fixed by Composer.
// TODO: Remove this check if firewall rules bug gets fixed by Composer.
{
PlanOnly: true,
ExpectNonEmptyPlan: false,
Expand Down Expand Up @@ -723,7 +723,7 @@ func TestAccComposerEnvironment_withUpdateOnCreate(t *testing.T) {
},
// This is a terrible clean-up step in order to get destroy to succeed,
// due to dangling firewall rules left by the Composer Environment blocking network deletion.
// TODO(emilyye): Remove this check if firewall rules bug gets fixed by Composer.
// TODO: Remove this check if firewall rules bug gets fixed by Composer.
{
PlanOnly: true,
ExpectNonEmptyPlan: false,
Expand Down
2 changes: 1 addition & 1 deletion tpgtools/overrides/compute/beta/forwarding_rule.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# TODO(ndmckinley): This one should be upstreamed to the DCL.
# TODO: This one should be upstreamed to the DCL.
- type: CUSTOM_ID
details:
id: projects/{{project}}/regions/{{region}}/forwardingRules/{{name}}
Expand Down
2 changes: 1 addition & 1 deletion tpgtools/overrides/compute/forwarding_rule.yaml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# TODO(ndmckinley): This one should be upstreamed to the DCL.
# TODO: This one should be upstreamed to the DCL.
- type: CUSTOM_ID
details:
id: projects/{{project}}/regions/{{region}}/forwardingRules/{{name}}
Expand Down

0 comments on commit 772cad9

Please sign in to comment.