Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

madsrdf:isMemberOfMADSScheme #100

Closed
kirkhess opened this issue Feb 1, 2019 · 3 comments
Closed

madsrdf:isMemberOfMADSScheme #100

kirkhess opened this issue Feb 1, 2019 · 3 comments
Assignees
@wafschneider
Labels
Bugs v1.4.0 Target for v1.4.0 release

Comments

@kirkhess
Copy link
Contributor

kirkhess commented Feb 1, 2019 •
edited
Loading

In https://github.com/lcnetdev/marc2bibframe2/blob/master/xsl/ConvSpec-648-662.xsl

Change madsrdf:isMemberofMADSScheme to madsrdf:isMemberOfMADSScheme

See http://id.loc.gov/ontologies/madsrdf/v1.html#p_isMemberOfMADSScheme

               <madsrdf:isMemberofMADSScheme>
                <xsl:attribute name="rdf:resource"><xsl:value-of select="."/></xsl:attribute>
              </madsrdf:isMemberofMADSScheme>
@kirkhess kirkhess added the Bugs label Feb 1, 2019
@kirkhess
Copy link
Contributor Author

kirkhess commented Feb 1, 2019

Also:
https://github.com/lcnetdev/marc2bibframe2/blob/4f3fcd3aa35280f1723a23cc5e216267e57bfffd/test/ConvSpec-1XX%2C6XX%2C7XX%2C8XX-names.xspec

https://github.com/lcnetdev/marc2bibframe2/blob/4f3fcd3aa35280f1723a23cc5e216267e57bfffd/test/marc2bibframe2.xspec

https://github.com/lcnetdev/marc2bibframe2/blob/4f3fcd3aa35280f1723a23cc5e216267e57bfffd/xsl/ConvSpec-1XX%2C6XX%2C7XX%2C8XX-names.xsl

https://github.com/lcnetdev/marc2bibframe2/blob/4f3fcd3aa35280f1723a23cc5e216267e57bfffd/xsl/ConvSpec-240andX30-UnifTitle.xsl

@dbs
Copy link

dbs commented Feb 11, 2019

See #103 for a fix, including fixes for the unit tests.

@wafschneider wafschneider added the v1.4.0 Target for v1.4.0 release label Feb 15, 2019
wafschneider added a commit that referenced this issue Feb 15, 2019
@wafschneider
Correct isMemberOfMADSScheme typo.
ec2c9aa 
Rebased commit from @dbs -- thank you! Fixes #100.
@wafschneider wafschneider mentioned this issue Feb 15, 2019
Merged
@wafschneider
Copy link
Collaborator

Fixed in v1.4.0 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wafschneider wafschneider

Labels
Bugs v1.4.0 Target for v1.4.0 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dbs @kirkhess @wafschneider