Use replace_regex to replace all occurrences of "." with "/" #1315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czgdp1807
approved these changes
Nov 19, 2022
| @@ -3408,7 +3408,7 @@ class SymbolTableVisitor : public CommonVisitor<SymbolTableVisitor> { | |||
| // Check for the nested modules with "." | |||
| // Example: from x.y import z | |||
| if (mod_sym.find(".") != std::string::npos) { | |||
| mod_sym.replace(mod_sym.find("."), 1, "/"); | |||
| mod_sym = replace(mod_sym, "[.]", "/"); | |||
There was a problem hiding this comment.
Seems like this was hard coded before.
There was a problem hiding this comment.
Previously, I thought replace() would replace every occurrence in the string. Now, I realize that it replaces only the first occurrence, or simply the index of the find().
|
Thanks for the approval. Let's merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #1305