Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

Document Updated for filter method #912

Closed
wants to merge 1 commit into from
Closed

Document Updated for filter method #912

wants to merge 1 commit into from

Conversation

devbysn
Copy link

@devbysn devbysn commented Jun 28, 2023

documentation for filter method updated.

@jsumners
Copy link
Member

Thank you for taking this on, @devbysn. When I opened the "good first issue" I expected that the true fix would be a while coming (as in, I didn't plan to deprecate the subX properties any time soon). But the work has been started by a community member in ldapjs/filter#5 to do just that. Given that PR is progressing, I think that changing this documentation would be unnecessary. What do you think?

@devbysn
Copy link
Author

devbysn commented Jun 28, 2023

Sure, @jsumners .
i will check other issues, will check if i can help in any.

@jsumners
Copy link
Member

Thanks. I'm going to go ahead and close this, and the issue, as being solved in a different manner.

@jsumners jsumners closed this Jun 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants