Skip to content

Commit

Permalink
Fix Codacy failures/warnings
Browse files Browse the repository at this point in the history
  • Loading branch information
ldeck committed Nov 27, 2017
1 parent b08541e commit 30dcbb7
Showing 1 changed file with 12 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,12 @@
import org.junit.runners.Parameterized;

import java.io.File;
import java.io.IOException;
import java.nio.file.Files;
import java.text.SimpleDateFormat;
import java.util.*;
import java.util.ArrayList;
import java.util.Collection;
import java.util.Date;
import java.util.Random;

import static java.lang.Boolean.FALSE;
import static java.lang.Boolean.TRUE;
Expand All @@ -24,21 +26,20 @@ public class DefaultRecordingFileFactoryTest {

private static final SimpleDateFormat DATE_FORMAT = new SimpleDateFormat("YYYYMMdd-HHmmss");

private final DefaultRecordingFileFactory factory = new DefaultRecordingFileFactory();
private final String methodName;
private final String prefix;
private final boolean success;

@Parameterized.Parameters
public static Collection<Object[]> data() {
Random random = new Random();
return new ArrayList<Object[]>() {{
add(new Object[]{format("testMethodName%d", random.nextInt()), "FAILED", FALSE});
add(new Object[]{format("testMethodName%d", random.nextInt()), "PASSED", TRUE});
}};
Collection<Object[]> args = new ArrayList<>();
args.add(new Object[]{format("testMethodName%d", random.nextInt()), "FAILED", FALSE});
args.add(new Object[]{format("testMethodName%d", random.nextInt()), "PASSED", TRUE});
return args;
}

private final DefaultRecordingFileFactory factory = new DefaultRecordingFileFactory();
private final String methodName;
private final String prefix;
private final boolean success;

@Test
public void recordingFileThatShouldDescribeTheTestResultAtThePresentTime() throws Exception {
File vncRecordingDirectory = Files.createTempDirectory("recording").toFile();
Expand Down

0 comments on commit 30dcbb7

Please sign in to comment.