Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Room tool: Duplicate room button does not copy everything #185

Closed
Claire1605 opened this issue Sep 21, 2022 · 2 comments
Closed

Room tool: Duplicate room button does not copy everything #185

Claire1605 opened this issue Sep 21, 2022 · 2 comments
Labels
bug javascript Pull requests that update Javascript code

Comments

@Claire1605
Copy link
Collaborator

When duplicating a room the items, avatar morph and room tune are not copied over to the new room
@le-doux le-doux added bug room-tool javascript Pull requests that update Javascript code labels Jan 22, 2023
@le-doux
Copy link
Owner

le-doux commented Jan 22, 2023

that's definitely a bug - thanks claire!

frojo added a commit to frojo/bitsy that referenced this issue Jul 30, 2023
@frojo
fix: Duplicate room button does not copy everything le-doux#185
5cbed18
le-doux added a commit that referenced this issue Dec 18, 2023
@le-doux
fix: Duplicate room button does not copy everything #185 (#228)
cf409a9 
* fix: Duplicate room button does not copy everything #185

* use copied items array instead of slice

---------

Co-authored-by: Adam Le Doux <adamrossledoux@gmail.com>
le-doux added a commit that referenced this issue Dec 19, 2023
@le-doux @vaasut
@seleb @pancelor
Version 8.8 (#246)
8691e84 
* Add information for uploadToItch.md (#235)

* Add information for uploadToItch.md

* Update docs/docs/faq/uploadToItch.md

Co-authored-by: Sean S. LeBlanc <sean.s.leblanc@gmail.com>

* Fix typos in docs/docs/faq/uploadToItch.md

Co-authored-by: Sean S. LeBlanc <sean.s.leblanc@gmail.com>

* Add closing tag for <img> to uploadToItch.md

Fix React Syntax Error : Expected corresponding JSX closing tag for <img>

---------

Co-authored-by: Sean S. LeBlanc <sean.s.leblanc@gmail.com>

* fix ClearCache tile memory leak (#232)

* fix off-by-one allocating

given these blocks:

4: occupied
5: occupied
6: undefined

and this call:
`_allocate({ start: 4, max: 2 })`

you would expect the allocation to fail and return null.
before this commit, this situation instead would allocate block 6

I don't know if this had any adverse effects; I just noticed it while
working on related stuff

* make sure ClearCache() deletes tile memory

fixes #230

* fix: Duplicate room button does not copy everything #185 (#228)

* fix: Duplicate room button does not copy everything #185

* use copied items array instead of slice

---------

Co-authored-by: Adam Le Doux <adamrossledoux@gmail.com>

* brazilian portuguese translation

---------

Co-authored-by: vaasut <vaasut1@gmail.com>
Co-authored-by: Sean S. LeBlanc <sean.s.leblanc@gmail.com>
Co-authored-by: pancelor <pancelor@gmail.com>
Co-authored-by: fran <mojoz0101@gmail.com>
@le-doux
Copy link
Owner

le-doux commented Apr 25, 2024

fixed

@le-doux le-doux closed this as completed Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@le-doux @Claire1605