LDR Importer options are not persisted

[MinnieTheMoocher]

As far as I can see, only the LDRAW directory option of LDR Importer
gets persisted.

Expected behaviour:
when I quit and restart Blender and then re-use LDR Importer,
its options should be as from the last run.
I.e, the value of options

• LDRAW Directory
• Scale
• "Use High-res bricks"
• Model Cleanup
  should be written to somewhere and be loaded on the next program run.

May I also ask to re-title the option "Use High-Res Bricks"?
It is very confusing. What it actually does is:
"Replace all Primitives by Hi-Res (48ed) Primitives".
This will be much clearer to LDRAW users.
It should be OFF by default.

May I also ask for a different default setting for the "Cleanup"?
The default IMHO should be "original LDRAW mesh".
Only when a user explicitly chooses to modify that mesh,
that should be done.

[le717]

/cc @rioforce I know you'll have a say in this.

[rioforce]

Not sure how we would do the persistent options, probably have to assign a number to each option and keep it in an external file. We could have a User Presets menu like we used to, but I think we had trouble with that because it messed up the LDraw path...

Use High-res bricks is always off by default. Renaming the option might work, although adding the specific details would be best in a tooltip. We'll also make an option of using Low-res bricks.

Using the original LDraw mesh might be good for LDraw CAD programs, but Blender is simply not a CAD program. It is a complete 3D modeling and rendering suite. We need to use a Blender Optimized Brick because there is lots of duplicate mesh on top of itself and it makes rendering, and editing painfully slow. Since the other LDraw CAD programs don't really use mesh, but rather coordinates in a file, they don't have messy mesh data. I think we should keep the Blender Optimized option by default.

[MinnieTheMoocher]

persistent options: just store them in config.py the same way as ldraw dir, that's all!
very simple!
i was just wondering why you only store the ldraw dir option there and the others not.

[le717]

I've updated the description for the high-res brick option, commit pending. How are those bricks officially referred to? I was also going to update the label, but I wasn't sure if "Use High-res (48ed) bricks" was correct or not.

The other import options were not stored in config.py because we were trying to ease the biggest (aside from the recursive class issues) issue with the script. It is completely possible to store the rest of the settings in it. I'll have to remember how we did it exactly, but this certainly can be done.

Assigned to milestone v1.2.

[MinnieTheMoocher]

They are not bricks. They are primitives.

Brick files use them in their implementation.

They are called High-Res Primitives.

What your option does is it toggles whether bricks using primitives
get the "normal" default resolution primitives, or, instead, always the high-res version.

IMHO the option should be called "Replace all primitives by High-Res versions".
That's what it actually does.

[le717]

I updated the button label in d29cb9e, tell me if that is correct now. I could not display "Replace all primitives by High-Res versions" because it was too long.

[le717]

I switched the milestone to v1.1.6 because this can be solved by re-enabling Blender presets (6d07dff8dd). However, this may create a conflict with the auto-detected/stored installation path on Windows (at least for this code base, #60 would not be affected, and neither would Mac OS X and Linux). I'll run some tests and see what happens.

[le717]

Per #66, reassigning to v1.3.

[le717]

Import options are now preserved by way of Blender operator presents (#65, 07ffba5). It will be present in the next release. Thanks for reporting this, @MinnieTheMoocher. 😃