added Stadia Maps to list of providers

[holtalanm]

https://stadiamaps.com/

ToS: https://docs.stadiamaps.com/#legal-stuff

Implementation from their documentation regarding Leaflet: https://docs.stadiamaps.com/raster/#displaying-a-map-leaflet

[brunob]

@jieter any thoughts ?

[jieter]

LGTM

[brunob]

Thx @holtalanm :)

[jieter]

Hmm, there is no preview API key configured, so http://leaflet-extras.github.io/leaflet-providers/preview/#filter=Stadia shows grey maps.

We should either keep it out of the preview, or add an example API code:

leaflet-providers/preview/shared.js

Lines 4 to 12 in 8627840

	var exampleAPIcodes = {
	'HERE': {
	'app_id': 'tFZyfnyJAmhfh5gdoGcR',
	'app_code': 'vJ8o9OCQ1o0Y2wwbRspzSA'
	},
	'Thunderforest': {
	'apikey': 'db5ae1f5778a448ca662554581f283c5'
	}
	};

[brunob]

As what i can read in their doc you don't need an API key to use the tiles, but the error is 403 Forbidden Request forbidden by administrative rules. , and i've seen this one while testing their static map API ref https://seenthis.net/messages/822843#message822884

So, there might be a temporary bug from their side ?

[holtalanm]

while their api has a free tier, users still need to have an account, and have their domain whitelisted within that account. This is explained in their leaflet documentation, as well:

everything should work seamlessly as long as you have an active plan for your domain

Not sure where that should be communicated within the leaflet-providers codebase, though.

[brunob]

@holtalanm so you should add this mention in the readme, and we should from our part don't list these tiles in the demo page.

[lseelenbinder]

Hi @holtalanm, @brunob, we (I'm co-founder of @stadiamaps) just added a property on our side allowing the preview domain (leaflet-extras.github.io). Are there any other domains we should add so there's not a weird grey space where our maps should be? 😄

[jieter]

@lseelenbinder leaflet-extras.github.io should be enough, thanks!