Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update lexers to Scintillua 5.3 #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Omikhleia
Copy link

@Omikhleia Omikhleia commented Apr 9, 2023

Greetings,

This PR is a proposal for updating the lexers to Scintillua 5.3 (Nov 2021), which includes 18 additional languages and various updates for other languages.

I didn't checked them all extensively -- TBH, I just tried the new typescript, the updated lua (which has a small update for Lua 5.4), and the bash and yaml lexers (just for a check, as I use them for documentation purpose).

The older lexers were from 2020, it seems, and retrieved from a source that's no longer available, with Scintillua being moved apart and now available on GitHub.

Scintillua 6.x (Sept.-Dec. 2022) introduces breaking changes, with partially (at this date) migrated lexers and "legacy" ones. I made a quick attempt and failed at it due to the weird compatibility shims -- So I went for the low-hanging fruit first, trying to upgrade at least to the latest official 5.x.

N.B. For the record, I forked this repository as hightligher.sile, as I eventually plan to use these lexers in a 3rd-party package for the SILE typesetting system, so as to get syntax highlighting in Markdown/Djot support for SILE -- but from a previous quick'n dirty attempt, it will likely sum up as an additional custom luarock spec, and one or two extra files (a pretty straightforward SILE package, and a simplified version of your own wrapper). Don't hesitate letting me know if a fork is indeed the way to go, or if the main repository would possibly welcome these additions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant