feat: Update lexers to Scintillua 5.3 #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings,
This PR is a proposal for updating the lexers to Scintillua 5.3 (Nov 2021), which includes 18 additional languages and various updates for other languages.
I didn't checked them all extensively -- TBH, I just tried the new
typescript, the updatedlua(which has a small update for Lua 5.4), and thebashandyamllexers (just for a check, as I use them for documentation purpose).The older lexers were from 2020, it seems, and retrieved from a source that's no longer available, with Scintillua being moved apart and now available on GitHub.
Scintillua 6.x (Sept.-Dec. 2022) introduces breaking changes, with partially (at this date) migrated lexers and "legacy" ones. I made a quick attempt and failed at it due to the weird compatibility shims -- So I went for the low-hanging fruit first, trying to upgrade at least to the latest official 5.x.
N.B. For the record, I forked this repository as hightligher.sile, as I eventually plan to use these lexers in a 3rd-party package for the SILE typesetting system, so as to get syntax highlighting in Markdown/Djot support for SILE -- but from a previous quick'n dirty attempt, it will likely sum up as an additional custom luarock spec, and one or two extra files (a pretty straightforward SILE package, and a simplified version of your own wrapper). Don't hesitate letting me know if a fork is indeed the way to go, or if the main repository would possibly welcome these additions.