Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enable watermarking and thumbnails and add helper methods #74

Merged
merged 3 commits into from
Oct 4, 2021
Merged

feat: Enable watermarking and thumbnails and add helper methods #74

merged 3 commits into from
Oct 4, 2021

Conversation

Abadulrehman
Copy link
Collaborator

This PR makes 2 changes related to "Renovation Image Settings":

  1. Adds the on_update File doc_event to hooks.py, so that "Auto Convert Thumbnails" and "Auto apply watermarks" settings work properly as intended i.e: Every image file uploaded to the site will generate thumbnails or have watermarks applied depending on the settings selected.
  2. Adds a helper method to easily retrieve the thumbnail URL of an image given information about the Doc it exists on.

Abadulrehman and others added 2 commits September 30, 2021 11:57
Co-authored-by: Elton Lobo <elton1231@gmail.com>
renovation_core/hooks.py Show resolved Hide resolved
renovation_core/utils/images.py Show resolved Hide resolved
Copy link
Member

@fahimalizain fahimalizain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 👍🏼

@assemmarwan assemmarwan merged commit 7c9d64d into leam-tech:master Oct 4, 2021
@Abadulrehman Abadulrehman deleted the enable_thumbnail_and_helper_methods branch October 5, 2021 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants