Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: priority of language set by generate_otp #79

Merged
merged 2 commits into from
Nov 25, 2021
Merged

refactor: priority of language set by generate_otp #79

merged 2 commits into from
Nov 25, 2021

Conversation

e-lobo
Copy link
Member

@e-lobo e-lobo commented Nov 17, 2021 •
edited
Loading

Priority of language set (frappe.local.lang) in generate_otp:

  1. lang kwarg
  2. Accept-Language header or from frappe.session.user (done by frappe )
  3. is user exists from medium_id (email or mobile) ie user.lang (ie Guest Users)

fahimalizain
fahimalizain reviewed Nov 23, 2021
View reviewed changes
renovation_core/utils/auth.py Outdated Show resolved Hide resolved
renovation_core/utils/auth.py Outdated Show resolved Hide resolved
@e-lobo e-lobo force-pushed the generate-otp-language-resolution branch 2 times, most recently from 21f0cc4 to 159a835 Compare November 24, 2021 09:05
@e-lobo e-lobo requested a review from fahimalizain November 24, 2021 09:05
@e-lobo e-lobo force-pushed the generate-otp-language-resolution branch from c966d03 to 9aea5eb Compare November 24, 2021 09:20
fahimalizain
fahimalizain approved these changes Nov 25, 2021
View reviewed changes
Copy link
Member

@fahimalizain fahimalizain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 👍🏼 👍🏼

Abadulrehman
Abadulrehman approved these changes Nov 25, 2021
View reviewed changes
Copy link
Collaborator

@Abadulrehman Abadulrehman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@e-lobo e-lobo requested a review from assemmarwan November 25, 2021 05:56
@assemmarwan assemmarwan merged commit 11466e6 into leam-tech:master Nov 25, 2021
@e-lobo e-lobo deleted the generate-otp-language-resolution branch November 25, 2021 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abadulrehman Abadulrehman Abadulrehman approved these changes

@fahimalizain fahimalizain fahimalizain approved these changes

@assemmarwan assemmarwan assemmarwan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@e-lobo @assemmarwan @fahimalizain @Abadulrehman