Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Broadcast Message): Whitelist send method #85

Merged
merged 1 commit into from
Apr 2, 2022
Merged

fix(Broadcast Message): Whitelist send method #85

merged 1 commit into from
Apr 2, 2022

Conversation

assemmarwan
Copy link
Member

Problem

Newer versions of frappe require methods that are used by the UI using runserverjob to be whitelisted. Since the send method of Broadcast Message is not whitelisted, Permission error is thrown.

Solution

Whitelist the method for logged in users.

@assemmarwan assemmarwan added the bug Something isn't working label Apr 2, 2022
@assemmarwan assemmarwan requested a review from fahimalizain April 2, 2022 04:37
@assemmarwan assemmarwan merged commit b2f2491 into master Apr 2, 2022
@fahimalizain fahimalizain deleted the broadcast_send_fix branch May 7, 2022 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fahimalizain fahimalizain fahimalizain approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@assemmarwan @fahimalizain