feat: add support for jpms #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgammon
added a commit
to elide-dev/jpms
that referenced
this pull request
Mar 16, 2024
Adds the `io.leangen.geantyref` project to the repository, after applying PR leangen/geantyref#29 Relates-To: leangen/geantyref#29 Signed-off-by: Sam Gammon <sam@elide.ventures>
sgammon
added a commit
to elide-dev/jpms
that referenced
this pull request
Mar 16, 2024
Adds the `io.leangen.geantyref` project to the repository, after applying PR leangen/geantyref#29 Relates-To: leangen/geantyref#29 Signed-off-by: Sam Gammon <sam@elide.ventures>
|
Hi @sgammon! |
|
@kaqqao yes, happy to do so :) |
- chore: add mvn build wrapper - chore: add java9-compliant implementations where needed - chore: remove `Automatic-Module-Name` Fixes and closes leangen#28 Signed-off-by: Sam Gammon <sam@elide.ventures>
|
@kaqqao Okay, I've pushed so that only the JPMS changes are included. Geantyref is now Java 9+ only. Some overrides needed to be added to comply with Java 9+ APIs, and I took the liberty of adding the I have been testing downstream in the JPMS Attic repo; this lets me exercise Geantyref against libraries that use it, with these changes applied. I'll report back if I encounter any issues. I expect tests to pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
module-info.javaso that Geantyref can be used from Modular Java apps.Fixes and closes #28 and #26
Changelog
Automatic-Module-Name