Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for jpms #29

Merged
merged 1 commit into from
Sep 1, 2024
Merged

feat: add support for jpms #29

merged 1 commit into from
Sep 1, 2024

Conversation

sgammon
Copy link

@sgammon sgammon commented Mar 16, 2024 •
edited
Loading

Summary

Adds a module-info.java so that Geantyref can be used from Modular Java apps.

Fixes and closes #28 and #26

Changelog

  • chore: add mvn build wrapper
  • chore: add compile run and srcroot for java9
  • chore: add java9-compliant implementations where needed
  • chore: add mrjar output
  • chore: remove Automatic-Module-Name

@sgammon sgammon mentioned this pull request Mar 16, 2024
Open
sgammon added a commit to elide-dev/jpms that referenced this pull request Mar 16, 2024
@sgammon
feat: add io.leangen.geantyref
9e8f491 
Adds the `io.leangen.geantyref` project to the repository, after
applying PR leangen/geantyref#29

Relates-To: leangen/geantyref#29
Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon sgammon mentioned this pull request Mar 16, 2024
Merged
sgammon added a commit to elide-dev/jpms that referenced this pull request Mar 16, 2024
@sgammon
feat: add io.leangen.geantyref (#30)
59d876f 
Adds the `io.leangen.geantyref` project to the repository, after
applying PR leangen/geantyref#29

Relates-To: leangen/geantyref#29

Signed-off-by: Sam Gammon <sam@elide.ventures>
@kaqqao
Copy link
Member

kaqqao commented Aug 18, 2024 •
edited
Loading

Hi @sgammon!
Thanks for this. Java 8 is ancient enough that I'd rather drop support for it and make this 9+ only. And, to be honest, I don't really want to maintain a multi-release. Would you mind changing your PR to accommodate for that?

@kaqqao kaqqao self-requested a review August 18, 2024 10:25
@sgammon
Copy link
Author

sgammon commented Aug 18, 2024 •
edited
Loading

@kaqqao happy to do so :)

@sgammon
feat: add support for jpms
f108b3a 
- chore: add mvn build wrapper
- chore: add java9-compliant implementations where needed
- chore: remove `Automatic-Module-Name`

Fixes and closes leangen#28

Signed-off-by: Sam Gammon <sam@elide.ventures>
@sgammon
Copy link
Author

sgammon commented Aug 18, 2024 •
edited
Loading

@kaqqao Okay, I've pushed so that only the JPMS changes are included. Geantyref is now Java 9+ only. Some overrides needed to be added to comply with Java 9+ APIs, and I took the liberty of adding the mvnw wrapper. Otherwise the PR is very clean.

I have been testing downstream in the JPMS Attic repo; this lets me exercise Geantyref against libraries that use it, with these changes applied. I'll report back if I encounter any issues. I expect tests to pass.

@sgammon sgammon mentioned this pull request Aug 18, 2024
Merged
@kaqqao kaqqao merged commit d789fe6 into leangen:master Sep 1, 2024
@kaqqao
Copy link
Member

kaqqao commented Sep 1, 2024

@sgammon Merged this, added the real implementations for the API introduced in Java 9 and released this as v2.0.0 🚀

@sgammon
Copy link
Author

sgammon commented Sep 1, 2024

Thank you @kaqqao! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaqqao kaqqao Awaiting requested review from kaqqao

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add module-info.java
2 participants
@sgammon @kaqqao