-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for jpms #29
base: master
Are you sure you want to change the base?
Conversation
Adds the `io.leangen.geantyref` project to the repository, after applying PR leangen/geantyref#29 Relates-To: leangen/geantyref#29 Signed-off-by: Sam Gammon <sam@elide.ventures>
Adds the `io.leangen.geantyref` project to the repository, after applying PR leangen/geantyref#29 Relates-To: leangen/geantyref#29 Signed-off-by: Sam Gammon <sam@elide.ventures>
Hi @sgammon! |
@kaqqao yes, happy to do so :) |
- chore: add mvn build wrapper - chore: add java9-compliant implementations where needed - chore: remove `Automatic-Module-Name` Fixes and closes leangen#28 Signed-off-by: Sam Gammon <sam@elide.ventures>
@kaqqao Okay, I've pushed so that only the JPMS changes are included. Geantyref is now Java 9+ only. Some overrides needed to be added to comply with Java 9+ APIs, and I took the liberty of adding the I have been testing downstream in the JPMS Attic repo; this lets me exercise Geantyref against libraries that use it, with these changes applied. I'll report back if I encounter any issues. I expect tests to pass. |
Summary
Adds a
module-info.java
so that Geantyref can be used from Modular Java apps.Fixes and closes #28 and #26
Changelog
Automatic-Module-Name