-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake/ci: add custom built clangd #204
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any estimate on how much this increases the build times?
Also, can I just enable the "clang-tools-extra" project and build only clangd? how long does that take compared to building everything together?
I am thinking that for a dev environment it's nice to have clangd, but rebuild it infrequently (it does not matter that it has all the latest commits) to avoid increasing the build times.
So I might want to build it in a separate build directory.
Looking at the CI for building windows and macos (those that don't use ccache) it seems that that building takes about 4-5 minutes longer
Yes you can, as for how long: I'm currently benchmarking build times but by seeing how many files it compiles, it is probably the same for building just Cheerp |
A clean build of only |
I also experimented a bit, but I had issues when only enabling clang-tools-extra. I had to still enable clang;clang-tools-extra and then only do Anyway, I think that it wold make sense to not build clangd on the CI on feature branches, since it would increase the feedback time for nothing. So the actionable items for you are:
|
I thought this worked, but I just built the all rule. However when trying to only build So the best cmake invocation that I have found to build only |
I believe it will now only build on the master branch, I'll give you a ping when I have verified that it indeed works. |
This change will add clangd to our packages. If you want to build clangd manually, you'll have to add `clang-tools-extra` to `LLVM_ENABLE_PROJECTS`. Also if you want it to get installed with the `install-distribution` rule, you'll have to specify `LLVM_ENABLE_PROJECTS` before specifying the initial cache with `-C` (see `debian/build.sh` for an example). This closes: leaningtech/cheerp-meta#144
This change will add clangd to our packages.
If you want to build clangd manually, you'll have to add
clang-tools-extra
toLLVM_ENABLE_PROJECTS
. Also if you want it to get installed with theinstall-distribution
rule, you'll have to specifyLLVM_ENABLE_PROJECTS
before specifying the initial cache with-C
(seedebian/build.sh
for an example).This closes: leaningtech/cheerp-meta#144