Prevent collapsing of secondary bases used inside a hierarchy where a downcast is done #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuri91
approved these changes
Jul 8, 2024
… downcast is done When a class is used inside a hierarchy where a downcast is performed on it cannot be collapsed. If it is collapsed the offset given by the downcast builtin will no longer be correct, causing unexpected behaviour
yuri91
force-pushed
the
fix-collapsed-downcast
branch
from
c816919 to
a513aa3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a class is used inside a hierarchy where a downcast is performed on it cannot be collapsed. If it is collapsed the offset given by the downcast builtin will no longer be correct, causing unexpected behavior