-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prettier configuration changed #160
Conversation
package.json
Outdated
@@ -10,7 +10,7 @@ | |||
"typescript": "^5.2.2" | |||
}, | |||
"prettier": { | |||
"trailingComma": "all", | |||
"trailingComma": "none", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a way to only remove the trailing commas for functions, but not on objects or arrays? I would like to minimize the impact on the repo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no option for that with prettier. You can only set trailing commas for "all", "es5" or "none".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see what is the impact of es5. The objective is to remove trailing commas in function calls, since it's really confusing and sloppy. If es5 does not do what we want we can use none
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"es5" keeps trailing commas for objects and arrays, but does not add them for function parameters.
I think "none" is the closest to what we want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"es5" keeps trailing commas for objects and arrays, but does not add them for function parameters.
This seems pretty much what I want
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah than I misunderstood! I'll be fixing it right now
3841bd9
to
1a3e4ed
Compare
No description provided.