updated native methods guide #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theodoravraimakis
force-pushed
the
native-methods-guide-update
branch
from
451852b to
24c2ae8
Compare
theodoravraimakis
force-pushed
the
native-methods-guide-update
branch
from
24c2ae8 to
b64809c
Compare
epanholz
requested changes
Nov 11, 2024
sites/cheerpj/src/content/docs/11-guides/implementing-native-methods.md
Outdated
Show resolved
Hide resolved
sites/cheerpj/src/content/docs/11-guides/implementing-native-methods.md
Outdated
Show resolved
Hide resolved
sites/cheerpj/src/content/docs/11-guides/implementing-native-methods.md
Outdated
Show resolved
Hide resolved
sites/cheerpj/src/content/docs/11-guides/implementing-native-methods.md
Outdated
Show resolved
Hide resolved
sites/cheerpj/src/content/docs/11-guides/implementing-native-methods.md
Outdated
Show resolved
Hide resolved
sites/cheerpj/src/content/docs/11-guides/implementing-native-methods.md
Outdated
Show resolved
Hide resolved
epanholz
approved these changes
Nov 18, 2024
GabrielaReyna
requested changes
Nov 19, 2024
There was a problem hiding this comment.
Thanks for the PR and great work. I have suggested a couple ofchanges regarding formatting.
I'd like to ask about the difference between this guide and "Implementing native methods and libraries". We will probably need to rename these guides to make it less confusing for the user since them two have very similar titles.
sites/cheerpj/src/content/docs/11-guides/implementing-native-methods.md
Outdated
Show resolved
Hide resolved
sites/cheerpj/src/content/docs/11-guides/implementing-native-methods.md
Outdated
Show resolved
Hide resolved
sites/cheerpj/src/content/docs/11-guides/implementing-native-methods.md
Outdated
Show resolved
Hide resolved
sites/cheerpj/src/content/docs/11-guides/implementing-native-methods.md
Outdated
Show resolved
Hide resolved
sites/cheerpj/src/content/docs/11-guides/implementing-native-methods.md
Outdated
Show resolved
Hide resolved
|
We decided to split the "Implementing native methods and libraries" guide into two separate ones, we heard from some customer that it is a bit difficult to understand so we also revamped them a bit. There is another PR with the standalone libraries guide. |
…ethods.md Co-authored-by: Ana Gabriela Reyna <gabrielareynaflores@gmail.com>
…ethods.md Co-authored-by: Ana Gabriela Reyna <gabrielareynaflores@gmail.com>
…ethods.md Co-authored-by: Ana Gabriela Reyna <gabrielareynaflores@gmail.com>
…ethods.md Co-authored-by: Ana Gabriela Reyna <gabrielareynaflores@gmail.com>
…ethods.md Co-authored-by: Ana Gabriela Reyna <gabrielareynaflores@gmail.com>
…ethods.md Co-authored-by: Ana Gabriela Reyna <gabrielareynaflores@gmail.com>
GabrielaReyna
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.