Added blog/video to CheerpX #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GabrielaReyna
requested changes
Nov 19, 2024
|
I think you need to move the video to the same folder where the blog .md file is ( Not |
GabrielaReyna
approved these changes
Nov 25, 2024
theodoravraimakis
pushed a commit
that referenced
this pull request
Dec 2, 2024
Co-authored-by: Ana Gabriela Reyna <gabrielareynaflores@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this added, the video works also when in the CheerpX blog section. The issue was that the path was not correct so it wasn't able to load any video at all.
I tried adding the right path to the .mp4 file in labs but video tag is not able to reach it when loading the website from the CheerpX website. Are all the branches (Cheerp, CheerpJ, CheerpX, labs) isolated from each other?