Added overview and licensing pages #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epanholz
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
This looks good to me.
@GabrielaReyna Please also have a look. Dora restructured the Applet Runner documentation a bit and added a licensing info page.
There was a problem hiding this comment.
The new content looks good to me. I have a question, was it intended to remove the landing page for the applet runner and be replaced with the overview?
- I am talking about this landing page: https://labs.leaningtech.com/docs/cheerpj-applet-runner
|
yes, removing that page is intended as it's a duplication of CJ.com content
…On Tue, 3 Dec 2024, 14:38 Ana Gabriela Reyna, ***@***.***> wrote:
***@***.**** commented on this pull request.
The new content looks good to me. I have a question, was it intended to
remove the landing page for the applet runner and be replaced with the
overview?
- I am talking about this landing page:
https://labs.leaningtech.com/docs/cheerpj-applet-runner
—
Reply to this email directly, view it on GitHub
<#182 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABM54KYUSFQAV6KF2FGSSSD2DW7AFAVCNFSM6AAAAABSVNYTBCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDINZVHA4DGMJSHE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
GabrielaReyna
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added overview and licensing page, moved some articles from ‘getting started’ to ‘guides’ section. Modification in DocsArticle.astro prevent applet runner and jnlp logos from becoming too big.