refactor(library/init/core): replace insert definition by export #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is the test failure related to this change? |
|
Yes, the CI error should be fixed now that I've merged master into this branch. I'm just trying to avoid merges as much as possible because the CI capacity in this repository is severely crippled: we can only do about one CI run every 2 hours or so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have both
has_insert.insertandinsert, which do exactly the same thing. This causes a bit of headache since built-in set notation useshas_insert.insertbut you typically writeinsert. We have a simp lemma in mathlib that replaceshas_insert.insertbyinsert, but then you can't use built-in set notation such as{a}in simp lemmas...