Change variable naming to make it less confusing #111
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hargoniX
requested changes
Sep 4, 2023
There was a problem hiding this comment.
Same issue as #112.
I would also suggest to keep the ?m naming since unassigned metavariables are to my knowledge always referred to as ?m.12345 in debug messages so it definitely aligns better with the actual user experience. How about changing the m : Nat instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the original text, the choice of
mis unfortunate, becausemis already bound in the type. While the meaning is clear, it made me to trip and re-parse the paragraph a few times, so I'm proposing this change for ease of reading.