[Merged by Bors] - chore: fix "unnecessary have" lint errors #13680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
llllvvuu
commented
Jun 10, 2024
•
llllvvuu
commented
For some reason, these only go off on my Lean PR testing branch. Some of the ones that went off there were genuinely unnecessary haves. Others were "unnecessary" for the def, but necessary for `decreasing_tactic`. Others were declarations getting flagged for depending on declarations that had unnecessary haves. I don't know which things are bugs in the linter, which things are bugs in my Lean patch, and which things are bugs related to what my Lean patch fixed.
llllvvuu
added
awaiting-review
easy
PR summaryImport changesNo significant changes to the import graph Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/no_lost_declarations.sh short <optional_commit>
## more verbose report:
./scripts/no_lost_declarations.sh <optional_commit> |
llllvvuu
changed the title
grunweg
approved these changes
Jun 10, 2024
|
Updated. |
Ruben-VandeVelde
approved these changes
Jun 10, 2024
|
🚀 Pull request has been placed on the maintainer queue by Ruben-VandeVelde. |
|
bors merge |
github-actions
bot
added
ready-to-merge
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 10, 2024
Co-authored-by: L Lllvvuu <git@llllvvuu.dev>
|
Pull request successfully merged into master. Build succeeded: |
mathlib-bors
bot
changed the title
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 12, 2024
This linter was silently not doing anything until leanprover/lean4#4410 was fixed, and now it is working so a backlog of warnings needed to be addressed. Some were addressed here: #13680. The warnings in this PRs are false positives (leanprover-community/batteries#428?), but a workaround is put in place. Co-authored-by: L Lllvvuu <git@llllvvuu.dev>
AntoineChambert-Loir
pushed a commit
that referenced
this pull request
Jun 20, 2024
Co-authored-by: L Lllvvuu <git@llllvvuu.dev>
AntoineChambert-Loir
pushed a commit
that referenced
this pull request
Jun 20, 2024
This linter was silently not doing anything until leanprover/lean4#4410 was fixed, and now it is working so a backlog of warnings needed to be addressed. Some were addressed here: #13680. The warnings in this PRs are false positives (leanprover-community/batteries#428?), but a workaround is put in place. Co-authored-by: L Lllvvuu <git@llllvvuu.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.