Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore: simplify a proof #22134

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - chore: simplify a proof #22134

wants to merge 2 commits into from

Conversation

AntoineChambert-Loir
Copy link
Collaborator

This simplifies a proof, as suggested by @acmepjz just after the preceding PR was merged.

Open in Gitpod

@AntoineChambert-Loir AntoineChambert-Loir mentioned this pull request Feb 20, 2025
Closed
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 20, 2025 •
edited
Loading

PR summary 38815f5920

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ one_def

You can run this locally as follows 
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.

No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Feb 20, 2025
@riccardobrasca
Copy link
Member

Can we avoid the change and use a rw? Thanks!

bors d+

@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 20, 2025

✌️ AntoineChambert-Loir can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@acmepjz
Copy link
Collaborator

acmepjz commented Feb 20, 2025

Can we avoid the change and use a rw? Thanks!

Seems that we don't have that for MvPolynomial, but only AddMonoidAlgebra.one_def, so I think it's probably "no".

@acmepjz
Copy link
Collaborator

acmepjz commented Feb 20, 2025

Also, what does @[nontriviality] tag for degree_one means? I think the condition of degree_one does not mention Subsingleton or Nontrivial. So the tag @[nontriviality] does nothing in this case I think.

@AntoineChambert-Loir
Copy link
Collaborator Author

I had added nontriviality tag in a moment of confusion…

@AntoineChambert-Loir
Copy link
Collaborator Author

I added the one_def lemma; it's likely to spare other changes.

@acmepjz
Copy link
Collaborator

acmepjz commented Feb 21, 2025

Thank you! I think this PR is good to go.

@AntoineChambert-Loir
Copy link
Collaborator Author

bors r+

mathlib-bors bot pushed a commit that referenced this pull request Feb 21, 2025
@AntoineChambert-Loir
chore: simplify a proof (#22134)
f6fae0f 
This simplifies a proof, as suggested by @acmepjz  just after the preceding PR was merged.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Feb 21, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title chore: simplify a proof [Merged by Bors] - chore: simplify a proof Feb 21, 2025
@mathlib-bors mathlib-bors bot closed this Feb 21, 2025
@mathlib-bors mathlib-bors bot deleted the ACL/MonOrder-add branch February 21, 2025 08:16
Julian added a commit that referenced this pull request Feb 21, 2025
@Julian
Merge remote-tracking branch 'origin/master' into polynomial-sequences
05a9447 
* origin/master: (823 commits)
  chore(Computability): fix naming of lemmas about Sum.inl, Sum.inr, Sum.casesOn (#22156)
  feat: `Fintype Ordering` (#22154)
  chore: more renamings to fit the naming convention (#22148)
  feat(CategoryTheory): any monomorphism in a Grothendieck abelian category is a transfinite composition of pushouts of monomorphisms in a small family (#22157)
  chore: rename `{Continuous., continuous_}sum_map` to `sumMap` (#22155)
  chore: remove initial space followed by `-/` (#22158)
  chore: make arg in HeightOneSpectrum.valuation explicit (#22139)
  feat(Data/List): `List.maximum` is monotone (#22091)
  chore(Combinatorics/SimpleGraph): extract WalkDecomp from Walk (#21981)
  feat: if a monoid M acts, then so does (s : S) with [SubmonoidClass S M] (#21123)
  chore: backport changes to `getElem` lemmas (#22146)
  feat(CategoryTheory): generating monomorphisms in Grothendieck abelian categories (#22150)
  feat: rename variables to fit doc (#22143)
  feat(CategoryTheory): IsDetecting.isIso_iff_of_mono (#22135)
  feat(CategoryTheory): truncations of transfinite compositions (#22149)
  chore: simplify a proof (#22134)
  feat(CategoryTheory): monomorphisms are stable under coproducts in Grothendieck abelian categories (#22133)
  feat(Order): Set.Ici.isSuccLimit_coe (#22103)
  chore(Analysis/Convex/Normed): split into smaller files (#22015)
  feat(Algebra/Algebra/Lie): max nilpotent ideal <= radical (#22140)
  refactor(LinearIndependent): refactor to use LinearIndepOn (#21886)
  chore: rename some more `Foo.sum_elim` -> `sumElim` (#22130)
  chore: rename Injective.sum_elim and friends (#22129)
  chore: fix naming oversight from #22070 (#22128)
  chore: fix spelling mistakes (#22136)
  feat(RingTheory/Ideal/Quotient): define transtition map between ring or module quotient by powers of ideal (#21900)
  fix: initialize_simps_projections print warning when projection data already exists (#20339)
  chore: rename ContMDiff.sum_{elim,map} (#22131)
  feat(CategoryTheory): characterization of injective objects in terms of lifting properties (#22104)
  chore(Lean,Tactic): un-indent some doc-strings (#22118)
  feat(Algebra/MvPolynomial): add `comp` versions of rename lemmas (#21259)
  chose: add deprecation (#22124)
  feat(CategoryTheory/Abelian/GrothendieckCategory): computing colimits in Subobject (#22123)
  feat(CategoryTheory/Subobject): hasCardinalLT_of_mono (#22122)
  feat: add `DenseRange.piMap` (#22114)
  feat(Algebra/Algebra/Lie): define the maximal nilpotent ideal of Lie algebras (#22061)
  chore(Data/Finset): don't import algebra when defining `Finset.card` (#21866)
  feat: a function on a discrete space is smooth (#22113)
  feat: commutative group objects in additive categories (#21521)
  style(Geometry/Manifold): remove superfluous indentation in doc-strings (#22117)
  chore: rename PushNeg.lean to Push.lean (#22108)
  feat: add Is{Open,Closed}Embedding.sum_elim (#22070)
  feat(RingTheory/Perfectoid): define the untilt map and generalize pretilt (#21563)
  feature(Topology/Algebra/Module/WeakBilin): Linear map from F into the topological dual of E with the weak topology (#21078)
  feat(CategoryTheory/Abelian): the exact sequence attached to a pushout square (#22110)
  chore(ChartedSpace.lean): group constructions together (#22107)
  feat(CategoryTheory/MorphismProperty): more basic API (#22099)
  chore(Data/Fintype): split `Fintype/Card.lean` (#21840)
  chore(SetTheory/Cardinal/Cofinality): make `IsStrongLimit` into a structure (#21971)
  feat(Combinatorics/SimpleGraph): Add a theorem about cliques in induced subgraphs (#20705)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acmepjz acmepjz acmepjz left review comments

Assignees

@acmepjz acmepjz

Labels
delegated t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AntoineChambert-Loir @riccardobrasca @acmepjz @leanprover-community-mathlib4-bot