Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: lake: no lean --githash when collocated #2572

Merged
merged 1 commit into from
Sep 22, 2023
Merged

perf: lake: no lean --githash when collocated #2572

merged 1 commit into from
Sep 22, 2023

Conversation

tydeu
Copy link
Member

@tydeu tydeu commented Sep 22, 2023

A follow-up to #2570 avoiding lean --githash when Lake is collocated with Lean. Benchmark results from my Windows machine:

$ hyperfine -w 3 "lake self-check" "external-lake self-check" --runs 50
Benchmark 1: lake self-check
  Time (mean ± σ):      94.5 ms ±   7.7 ms    [User: 52.5 ms, System: 43.1 ms]
  Range (min … max):    86.1 ms … 118.5 ms    50 runs

Benchmark 2: external-lake self-check
  Time (mean ± σ):     207.5 ms ±  17.3 ms    [User: 142.2 ms, System: 66.6 ms]
  Range (min … max):   187.6 ms … 267.0 ms    50 runs

Summary
  'lake self-check' ran
    2.20 ± 0.26 times faster than 'external-lake.exe self-check'

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Sep 22, 2023
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Sep 22, 2023
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#2572
6f7163f
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Sep 22, 2023
@leanprover-community-mathlib4-bot
Copy link
Collaborator

@tydeu tydeu merged commit 16ceb4b into leanprover:master Sep 22, 2023
15 checks passed
@tydeu tydeu deleted the no-lean-githash branch September 22, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tydeu @leanprover-community-mathlib4-bot