Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cloud release trace & lake build :release errors #3248

Merged
merged 2 commits into from
Feb 17, 2024

Conversation

tydeu
Copy link
Member

@tydeu tydeu commented Feb 2, 2024

Fixes a bug with Lake cloud releases where a cloud release would produce a different trace if the package was the root of the workspace versus a dependency. Also, an explicit fetch of a cloud release (e.g., via lake build :release) will now error out with a non-zero exit code if it fails to find, download, and unpack a release.

@tydeu tydeu added the full-ci label Feb 2, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Feb 2, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Feb 2, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Feb 2, 2024
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Feb 2, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented Feb 2, 2024

Mathlib CI status (docs):

@tydeu tydeu changed the title fix: lake: cloud release trace fix: cloud release trace & lake build :release errors Feb 2, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Feb 3, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Feb 3, 2024
@tydeu tydeu added the will-merge-soon …unless someone speaks up label Feb 5, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Feb 5, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Feb 5, 2024
@tydeu tydeu added this pull request to the merge queue Feb 17, 2024
github-merge-queue bot pushed a commit that referenced this pull request Feb 17, 2024
Fixes a bug with Lake cloud releases where a cloud release would produce
a different trace if the package was the root of the workspace versus a
dependency. Also, an explicit fetch of a cloud release (e.g., via `lake
build :release`) will now error out with a non-zero exit code if it
fails to find, download, and unpack a release.
Merged via the queue into leanprover:master with commit 3fb7262 Feb 17, 2024
37 checks passed
@tydeu tydeu deleted the lake/release-trace-fix branch February 17, 2024 04:20
arthur-adjedj pushed a commit to arthur-adjedj/lean4 that referenced this pull request Feb 19, 2024
)

Fixes a bug with Lake cloud releases where a cloud release would produce
a different trace if the package was the root of the workspace versus a
dependency. Also, an explicit fetch of a cloud release (e.g., via `lake
build :release`) will now error out with a non-zero exit code if it
fails to find, download, and unpack a release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN will-merge-soon …unless someone speaks up
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants