fix: offset typeclass checking in simp rules #3838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!bench |
This changes how Nat typeclass checks in offset terms from syntactic equality to definitional equality with "instances" transparency. This may have a negative performance penalty in `isOffset?`, but it should be small in common cases since the relevant instances are small terms.
joehendrix
force-pushed
the
fix_nat_class_defeq_simp
branch
from
042b1df
to
6dddf98
Compare
|
Here are the benchmark results for commit 042b1df. Benchmark Metric Change
====================================
- stdlib dsimp 4.4% (18.1 σ) |
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes how Nat typeclass checks in offset terms from syntactic equality to definitional equality with "instances" transparency.
This may have a negative performance penalty in
isOffset?, but it should be small in common cases since the relevant instances are small terms.This closes #3836