-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: lemmas to simplify equalities with Option
-typed dependent if-then-else
#4037
Conversation
Mathlib CI status (docs):
|
Hmm, looks like this breaks mathlib, this might need diagnosing |
It looks like the problem could be with the use of a non-final |
The errors was thrown in
But the proof can be simplified as follows now:
There may be other problems like this and I'm trying to compile Mathlib locally to identify them. Where should I push the fix? To the |
Exactly! Just keep pushing fixed until mathlib is happy, then we can see if the changes needed are benign |
Changes to Mathlib look fine, so lets proceed! |
Closes #4013.
Add
dite_some_none_eq_none
anddite_some_none_eq_some
, analogous to the existingite_some_none_eq_none
andite_some_none_eq_some
.