Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: lake: TOML key order bug in ppTable #4104

Merged
merged 1 commit into from
May 10, 2024
Merged

fix: lake: TOML key order bug in ppTable #4104

merged 1 commit into from
May 10, 2024

Conversation

tydeu
Copy link
Member

@tydeu tydeu commented May 8, 2024 •
edited
Loading

Fixes a bug in Lake.Toml.ppTable where root table keys could be printed after a subtable header.

Closes #4099.

@tydeu tydeu added this to the v4.8.0-rc2 milestone May 8, 2024
@tydeu tydeu marked this pull request as ready for review May 8, 2024 01:14
@tydeu tydeu added the will-merge-soon …unless someone speaks up label May 8, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label May 8, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request May 8, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#4104
a911cca
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request May 8, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#4104
fba2f49
@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label May 8, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

leanprover-community-mathlib4-bot commented May 8, 2024 •
edited
Loading

Mathlib CI status (docs):

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request May 8, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4104
20600e4
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request May 8, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4104
56928bb
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request May 8, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4104
f8115c2
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request May 8, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#4104
6c62ad8
@tydeu tydeu added this pull request to the merge queue May 10, 2024
Merged via the queue into leanprover:master with commit ca6437d May 10, 2024
30 of 35 checks passed
github-actions bot pushed a commit that referenced this pull request May 10, 2024
@tydeu @github-actions
fix: lake: TOML key order bug in ppTable (#4104)
432e0f3 
Fixes a bug in `Lake.Toml.ppTable` where root table keys could be
printed after a subtable header.

Closes #4099.

(cherry picked from commit ca6437d)
@github-actions github-actions bot mentioned this pull request May 10, 2024
Merged
kim-em pushed a commit that referenced this pull request May 10, 2024
@tydeu @kim-em
fix: lake: TOML key order bug in ppTable (#4104)
a4d7e81 
Fixes a bug in `Lake.Toml.ppTable` where root table keys could be
printed after a subtable header.

Closes #4099.

(cherry picked from commit ca6437d)
kim-em pushed a commit that referenced this pull request May 21, 2024
@tydeu @kim-em
fix: lake: TOML key order bug in ppTable (#4104)
1b0f52d 
Fixes a bug in `Lake.Toml.ppTable` where root table keys could be
printed after a subtable header.

Closes #4099.

(cherry picked from commit ca6437d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport releases/v4.8.0 builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN will-merge-soon …unless someone speaks up
Projects
None yet
Milestone
v4.8.0-rc2
Development

Successfully merging this pull request may close these issues.

Lake fails to parse result of config translation script
2 participants
@tydeu @leanprover-community-mathlib4-bot