Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid unnecessary proof steps in simp #4567

Merged
merged 2 commits into from
Jun 26, 2024
Merged

fix: avoid unnecessary proof steps in simp #4567

merged 2 commits into from
Jun 26, 2024

Conversation

leodemoura
Copy link
Member

closes #4534

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc June 26, 2024 05:41 Inactive
@leodemoura leodemoura added this pull request to the merge queue Jun 26, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jun 26, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 230f33570256016e658abe48cca9a08e411d9f4b --onto 49249b91074a8eab8926308cedc2b3e31d973b51. (2024-06-26 05:50:44)

Merged via the queue into master with commit 62b6e58 Jun 26, 2024
13 checks passed
mo271 added a commit to leanprover-community/mathlib4 that referenced this pull request Jul 16, 2024
@mo271
chore: remove superfluous ge_iff_le
4fad384 
These were likely introduced by calling simp?, but are not necessary.

This is fixed in leanprover/lean4#4567, so now
might be a good time for cleaning them up.
@mo271 mo271 mentioned this pull request Jul 16, 2024
Closed
mathlib-bors bot pushed a commit to leanprover-community/mathlib4 that referenced this pull request Jul 16, 2024
@mo271
chore: remove superfluous ge_iff_le (#14785)
1c5837c 
These were likely introduced by calling simp?, but are not necessary.

This is fixed in leanprover/lean4#4567, so now might be a good time for cleaning them up.




Co-authored-by: Moritz Firsching <firsching@google.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

simp regression: simp? returns unuseful lemmas
2 participants
@leodemoura @leanprover-community-mathlib4-bot