fix: enforce isDefEqStuckEx at unstuckMVar procedure
#4596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jul 1, 2024
kim-em
added
the
release-ci
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jul 1, 2024
|
Mathlib CI status (docs):
|
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jul 1, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jul 1, 2024
kim-em
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jul 2, 2024
|
I'm sorry, I don't understand why the Mathlib CI is failing here. @leodemoura, I have a local build of Mathlib with only minor changes, if you want to proceed. |
|
The Mathlib CI is failing with: @tydeu, a resolution to #4302 would be really helpful here, as it's hard to guess what is happening. Locally everything works fine. |
and use `#guard_msgs`
Closes #2736 See comment at `ExprDefEq.lean` for explanation. Side effects: - Improved error messages in two tests. - Had to improve `getSuccesses` procedure at `App.lean`. It now discards candidates that contain postponed elaboration problems. If it is too disruptive for Mathlib, we should try to discard the ones that have postponed metavariables.
leodemoura
force-pushed
the
issue_2736_defeq
branch
from
897778c
to
269a66d
Compare
|
@semorrison In the meantime, I rebased on top of the new nightly-with-mathlib and resubmitted. |
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jul 2, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jul 2, 2024
leanprover-community-mathlib4-bot
added
the
builds-mathlib
cruhland
added a commit
to cruhland/lean4-axiomatic
that referenced
this pull request
Jul 7, 2024
A bug caused by leanprover/lean4#4596 prevents us from updating to latest
cruhland
added a commit
to cruhland/lean4-analysis
that referenced
this pull request
Jul 7, 2024
A bug caused by leanprover/lean4#4596 prevents us from updating to latest
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2736
See comment at
ExprDefEq.leanfor explanation.Side effects:
getSuccessesprocedure atApp.lean. It nowdiscards candidates that contain postponed elaboration problems.
If it is too disruptive for Mathlib, we should try to discard the
ones that have postponed metavariables.