Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make constructor-as-variable test more robust #4625

Merged
merged 1 commit into from
Jul 2, 2024
Merged

chore: make constructor-as-variable test more robust #4625

merged 1 commit into from
Jul 2, 2024

Conversation

TwoFX
Copy link
Member

@TwoFX TwoFX commented Jul 2, 2024

The test tended to fail every time the number of structures in Init changes, which turns out to be quite often.

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc July 2, 2024 09:00 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Jul 2, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 554e7234330cf06efffe0cb52092e783a27561cc --onto 4d0b7cf66c140dd83f8c8634293047335a385026. (2024-07-02 09:11:27)

david-christiansen
david-christiansen approved these changes Jul 2, 2024
View reviewed changes
Copy link
Contributor

@david-christiansen david-christiansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good change!

@TwoFX TwoFX added this pull request to the merge queue Jul 2, 2024
Merged via the queue into master with commit 8959b2c Jul 2, 2024
13 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@david-christiansen david-christiansen david-christiansen approved these changes

Assignees
No one assigned
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TwoFX @leanprover-community-mathlib4-bot @david-christiansen