Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mixing variable binder updates and declarations #5142

Merged
merged 2 commits into from
Aug 23, 2024
Merged

fix: mixing variable binder updates and declarations #5142

merged 2 commits into from
Aug 23, 2024

Conversation

Kha
Copy link
Member

@Kha Kha commented Aug 23, 2024

Fixes #2143

@Kha Kha enabled auto-merge August 23, 2024 09:15
@Kha Kha added this pull request to the merge queue Aug 23, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Aug 23, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Mathlib CI can not be attempted yet, as the nightly-testing-2024-08-23 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-mathlib, Mathlib CI should run now. (2024-08-23 09:34:42)

@grunweg
Copy link
Contributor

grunweg commented Aug 23, 2024

This PR is great, thanks for working on it! Does this also close #2789?

Merged via the queue into leanprover:master with commit 390a9a6 Aug 23, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changing variable type and introducing new variables cannot be done in one command.
3 participants
@Kha @leanprover-community-mathlib4-bot @grunweg