Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: make extractLsb' the primitive bv_decide understands, rather than extractLsb #5211

Merged
merged 4 commits into from
Sep 4, 2024
Merged

refactor: make extractLsb' the primitive bv_decide understands, rather than extractLsb #5211

merged 4 commits into from
Sep 4, 2024

Conversation

alexkeizer
Copy link
Contributor

@alexkeizer alexkeizer commented Aug 30, 2024 •
edited
Loading

We change the bv_decide to understand BitVec.extractLsb' as a primitive, and add a normalization lemma for extractLsb.
It's important to pick the primed version as a primitive, because it is not always possible to rewrite extractLsb' back into extractLsb (see #5007 for that direction, and the relevant side-conditions).

That is, with this PR, bv_decide is able to bitblast both versions of extracting bits.

@alexkeizer alexkeizer marked this pull request as ready for review September 3, 2024 21:22
@alexkeizer alexkeizer requested a review from hargoniX as a code owner September 3, 2024 21:22
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Sep 3, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 4eea57841d1012d6c2edab0f270e433d43f92520 --onto 4f04112446a10ef996fdfed10e3991f2cafadc4a. (2024-09-03 22:03:12)

@hargoniX hargoniX added the will-merge-soon …unless someone speaks up label Sep 4, 2024
@hargoniX hargoniX added this pull request to the merge queue Sep 4, 2024
Merged via the queue into leanprover:master with commit fa8439a Sep 4, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hargoniX hargoniX hargoniX approved these changes

Assignees
No one assigned
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN will-merge-soon …unless someone speaks up
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexkeizer @leanprover-community-mathlib4-bot @hargoniX