Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: must not reduce ite in the discriminant of match-expression when reducibility setting is .reducible #5419

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

leodemoura
Copy link
Member

closes #5388

See updated comment for additional details.

…en reducibility setting is `.reducible`

closes #5388
@leodemoura
Copy link
Member Author

@semorrison @jcommelin This PR will probably break Mathlib at simp only [...] occurrences, but the fixes should be similar to the one at RupAddResult.lean.

@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc September 23, 2024 01:09 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Sep 23, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Sep 23, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Sep 23, 2024
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Sep 23, 2024
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

@kim-em
Copy link
Collaborator

kim-em commented Sep 23, 2024

Magically no breakages. :-)

@leodemoura leodemoura added this pull request to the merge queue Sep 23, 2024
Merged via the queue into master with commit fc20b5d Sep 23, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
3 participants