feat: BitVec.getMsbD in bv_decide #5987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TwoFX
reviewed
Nov 7, 2024
| a[i]'h = a.getLsbD i := by | ||
| simp [BitVec.getLsbD_eq_getElem?_getD, BitVec.getElem?_eq, h] | ||
|
|
||
| -- The side condition about gets resolved if i and w are constant. |
There was a problem hiding this comment.
This comment seems to be missing some words?
TwoFX
reviewed
Nov 7, 2024
| @@ -38,3 +38,5 @@ theorem bitwise_unit_9 (x y : BitVec 32) : | |||
| BitVec.ofBool (x.getLsbD 0 ^^ y.getLsbD 0) = BitVec.ofBool ((x ^^^ y).getLsbD 0) := by | |||
| bv_decide | |||
|
|
|||
| theorem bitwise_unit_10 (x : BitVec 2): (x.getMsbD 0) = x.msb := by | |||
There was a problem hiding this comment.
Suggested change
| theorem bitwise_unit_10 (x : BitVec 2): (x.getMsbD 0) = x.msb := by | |
| theorem bitwise_unit_10 (x : BitVec 2) : (x.getMsbD 0) = x.msb := by |
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 7, 2024
Address comments by Markus in #5987
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5983.