-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: change Array.get
to take a Nat
and a proof
#6032
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kim-em
requested review from
TwoFX,
digama0,
david-christiansen,
leodemoura and
mhuisi
as code owners
November 11, 2024 10:06
github-actions
bot
added
the
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
label
Nov 11, 2024
Mathlib CI status (docs):
|
One very minor docstring quibble. It looks like this changeset touches lots of code, and basically all of it gets nicer. That's a nice outcome! |
Co-authored-by: David Thrane Christiansen <david@davidchristiansen.dk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
changelog-library
Library
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the signature of
Array.get
to take a Nat and a proof, rather than aFin
, for consistency with the rest of the (planned) Array API. Note that because of bootstrapping issues we can't provideget_elem_tactic
as an autoparameter for the proof. As users will mostly use thexs[i]
notation provided byGetElem
, this hopefully isn't a problem.We may restore
Fin
based versions, either here or downstream, as needed, but they won't be the "main" functions.