-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: more UInt lemmas #6205
Merged
Merged
feat: more UInt lemmas #6205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
label
Nov 25, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Nov 25, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 25, 2024
leanprover-community-bot
added
the
breaks-mathlib
This is not necessarily a blocker for merging: but there needs to be a plan
label
Nov 25, 2024
Mathlib CI status (docs):
|
tydeu
force-pushed
the
more-uint-lemmas
branch
from
November 28, 2024 07:17
af1b586
to
5b71053
Compare
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Nov 28, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 28, 2024
tydeu
added a commit
to leanprover-community/batteries
that referenced
this pull request
Nov 28, 2024
tydeu
added a commit
to tydeu/std4
that referenced
this pull request
Nov 28, 2024
tydeu
added a commit
to leanprover-community/batteries
that referenced
this pull request
Nov 28, 2024
tydeu
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 28, 2024
leanprover-community-bot
added
builds-mathlib
CI has verified that Mathlib builds against this PR
and removed
breaks-mathlib
This is not necessarily a blocker for merging: but there needs to be a plan
labels
Nov 28, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Nov 28, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 28, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Nov 29, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
builds-mathlib
CI has verified that Mathlib builds against this PR
changelog-library
Library
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upstreams some UInt theorems from Batteries and adds more
toNat
-related theorems. It also adds the missingUInt8
andUInt16
to/fromUSize
conversions so that the the interface is uniform across the UInt types.Summary of all changes:
toNat
constructors lemmas:toNat_mk
,ofNat_toNat
,toNat_ofNat
,toNat_ofNatCore
, andUSize.toNat_ofNat32
toNat
canonicalization;val_val_eq_toNat
andtoNat_toBitVec_eq_toNat
toBitVec_inj
,toNat_inj
, andval_inj
le_iff_toNat_le
andlt_iff_toNat_lt
le_antisymm
andle_antisymm_iff
toNat
lemmas on arithmetic operations:toNat_add
,toNat_sub
,toNat_mul
toNat_toUInt*
andtoNat_USize
USize
conversions:USize.toUInt8
,UInt8.toUSize
,USize.toUInt16
,UInt16.toUSize