-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some basic snippets #214
base: master
Are you sure you want to change the base?
Conversation
I think these could prove to be fairly controversial. You automatically get a lot of text when you type Note that it's also possible to add the snippets to e.g. mathlib. |
We could, but there are already extensions to manage unwanted snippets like https://github.com/svipas/vscode-control-snippets. microsoft/vscode#10565 is related. |
Ok, so I've tried them out a bit.
I've posted a thread in the PR reviews stream on zulip. |
":=", | ||
"\t${3:(field : sorry)}", | ||
"", | ||
"namespace ${1:}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The lines below are a little too much. structure
should not make too much assumption on the organization after the structure. If this snippet is called theory
for boilerplate of developing a theory, maybe it would be OK but there would be much more.
"\t${3:(field : sorry)}", | ||
"", | ||
"namespace ${1:}", | ||
"variables ${2:}", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually variables should be declared in a named section.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Declaring variables in a namespace is fine too.
Not sure if these are really all that useful, but though I'd suggest them anyway.