fix: remove invisible doc filtering #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the last iteration of invisible doc filtering that was introduced in #460, which would sometimes filter visible documents due to event ordering issues with the
window.tabGroupsAPI of VS Code.Fixes #484 and another issue reported at https://leanprover.zulipchat.com/#narrow/stream/270676-lean4/topic/Server.20crashes.20on.20new.20file/near/447351002.
With the removal of this code, VS Code will now sometimes open invisible documents in the language server. In my testing, this is not much of an issue for the most common kind of invisible documents (
Ctrl+ hovering over an identifier).The other issue for which we introduced this handling in the first place was that the VS Code extension would start looping when using
Ctrl+ Hover (leanprover/lean4#367), but this issue has been resolved separately since we removed the vscode-lean compatibility layer (#426), and so it is not an issue anymore.For more details, see microsoft/vscode-languageserver-node#848 (comment).