Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise on warnings during CI #119

Merged
merged 4 commits into from
Dec 20, 2023
Merged

Raise on warnings during CI #119

merged 4 commits into from
Dec 20, 2023

Conversation

jbusecke
Copy link
Contributor

@jbusecke jbusecke commented Dec 19, 2023

This will ensure that missing references etc are detected as part of the CI

By changing the execution command to jupyter-book build -W --keep-going . we fail on warnings, but also list all of the warnings with the output in the log.

This PR includes:

  • homogenization of reference style from e.g. hub:data to hub.data
  • Fixes necessary to make the build pass without any warnings.

Copy link

github-actions bot commented Dec 19, 2023

👋 Thanks for opening this PR! The Cookbook will be automatically built with GitHub Actions. To see the status of your deployment, click below.
🔍 Git commit SHA: c4f1f05
✅ Deployment Preview URL: https://leap-stc.github.io/_preview/119

@jbusecke jbusecke merged commit f95169b into main Dec 20, 2023
1 check passed
github-actions bot pushed a commit that referenced this pull request Dec 20, 2023
@jbusecke jbusecke mentioned this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant