-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for Node version >=12 #396
Conversation
@simonweniger please review, adding this comment in case auto review request is not created. Thanks :) |
@troggy can you review this ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Review steps:
- I checkout latest master, ran
yarn
with node 11 and it worked fine. - I switched to node 12, and got an error after running
yarn
. - I checked-out this branch.
- Ran
yarn
andyarn test
on both node 11 and node 12, both working fine.
@simonweniger I've submitted this as work on Gitcoin, please have a look. Thanks :) |
@agbilotia1998 payout done, thank you for the contribution. We would love to have you as a contributor. So pleas check other available bountys at leapdao.org/earn. You also will recive LeapTokens as a reputation payment, so make sure you aktivate them in your wallet. This is the Leap Token adress: 0x78230e69d6e6449db1e11904e0bd81c018454d7a |
I've added Leap Token to my account, sure I'll have a look at other bounties as well. Thanks :) |
I've found one side effect for using leap-node with node 12. leap-node uses Related issue: cryptocoinjs/keccak#10 (resolved in keccak@2.1.0, but latest ethereumjs-util still uses older version) /cc @TheReturnOfJan |
How to check: if your installation uses js implementation of keccak you will see this on startup: |
Fixes #346