-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #222 simple balance crash #244
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yap, but it's not i18next issue. That's simply browser implementation of Intl.NumberFormat: And, my guess, is that iOS Safari is not implementing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for reviewing this after it has been merged. About my comment, we can talk here and decide if we want to address it in another PR.
@@ -20,6 +20,12 @@ | |||
integrity="sha384-B4dIYHKNBt8Bc12p+WXckhzcICo0wtJAoU8YZTY5qE0Id1GSseTk6S+L3BlXeVIU" | |||
crossorigin="anonymous" | |||
/> | |||
|
|||
<link |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure this belongs to this PR. Also, I'd serve the font from the burner wallet domain itself, to avoid sharing information with the big G.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, that adding font should have been gone into another issue 🙇♂️
But can you tell us what is the concerns? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, what I would like to avoid is loading assets from Google's servers because I'm concerned about privacy. The less data points we give to Google, the better, so I would prefer if we can download the resource and serve it from "our servers".
Fixes #222
@TimDaub users who had esperiences crash before now should be able to access their funds :)