Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test cases for getId() method #18

Merged
merged 6 commits into from
Jul 31, 2019
Merged

Add test cases for getId() method #18

merged 6 commits into from
Jul 31, 2019

Conversation

cham11ng
Copy link
Contributor

@cham11ng cham11ng commented Jul 31, 2019 •
edited by mesaugat
Loading

  • Add test cases for getId() method
  • Update doc for getId()

Closes #15

@cham11ng cham11ng added the test label Jul 31, 2019
@cham11ng cham11ng self-assigned this Jul 31, 2019
@cham11ng cham11ng mentioned this pull request Jul 31, 2019
Closed
@mesaugat mesaugat merged commit d2d2d57 into master Jul 31, 2019
@mesaugat mesaugat deleted the test-get-id branch July 31, 2019 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mesaugat mesaugat mesaugat approved these changes

@kabirbaidhya kabirbaidhya Awaiting requested review from kabirbaidhya

Assignees

@cham11ng cham11ng

Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make store.getId() fail-safe
3 participants
@cham11ng @kabirbaidhya @mesaugat