Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs are misleading in rollback / teardown stage #5

Closed
SafalPandey opened this issue Aug 9, 2019 · 1 comment · Fixed by #28
Closed

Logs are misleading in rollback / teardown stage #5

SafalPandey opened this issue Aug 9, 2019 · 1 comment · Fixed by #28
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@SafalPandey
Copy link
Contributor

SafalPandey commented Aug 9, 2019

Issue

When the folder names where the database objects are in do not match one of procedure, schema, view or function, the logs explicitly say Rolling back <object name> and Executed: <xx> ms However the objects aren't removed from the database.

Expected behavior

I think it should raise an error instead. We need to make it clear that the directory name did not match the expected convention and raise an error if rollback script is not executed.

Log trail

  sync-db:db1 Synchronize database +0ms
  sync-db:db1 Running rollback on a database: db1 +0ms
  sync-db:db1 Rolling back: etl.noop +0ms
  sync-db:db1 Executed:   +48ms
  sync-db:db1 Rolling back: etl +0ms
  sync-db:db1 Executed:   +2ms
  sync-db:db1 Finished running rollback +273ms
  sync-db:db1 Running setup +0ms
  sync-db:db1 Running schemas/etl.sql +0ms
  sync-db:db1 Running procedures/etl/noop.sql +0ms
  sync-db Error caught:  { TransactionError: Transaction has been aborted.
...
@kabirbaidhya kabirbaidhya added the bug Something isn't working label Aug 9, 2019
@kabirbaidhya kabirbaidhya added the good first issue Good for newcomers label Nov 27, 2019
@parwatcodes
Copy link
Contributor

I'll be working on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants