You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When the folder names where the database objects are in do not match one of procedure, schema, view or function, the logs explicitly say Rolling back <object name> and Executed: <xx> ms However the objects aren't removed from the database.
Expected behavior
I think it should raise an error instead. We need to make it clear that the directory name did not match the expected convention and raise an error if rollback script is not executed.
Log trail
sync-db:db1 Synchronize database +0ms
sync-db:db1 Running rollback on a database: db1 +0ms
sync-db:db1 Rolling back: etl.noop +0ms
sync-db:db1 Executed: +48ms
sync-db:db1 Rolling back: etl +0ms
sync-db:db1 Executed: +2ms
sync-db:db1 Finished running rollback +273ms
sync-db:db1 Running setup +0ms
sync-db:db1 Running schemas/etl.sql +0ms
sync-db:db1 Running procedures/etl/noop.sql +0ms
sync-db Error caught: { TransactionError: Transaction has been aborted.
...
The text was updated successfully, but these errors were encountered:
Issue
When the folder names where the database objects are in do not match one of
procedure
,schema
,view
orfunction
, the logs explicitly sayRolling back <object name>
andExecuted: <xx> ms
However the objects aren't removed from the database.Expected behavior
I think it should raise an error instead. We need to make it clear that the directory name did not match the expected convention and raise an error if rollback script is not executed.
Log trail
The text was updated successfully, but these errors were encountered: