Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw an error if object type names doesn't match directory convention #28

Conversation

parwatcodes
Copy link
Contributor

@parwatcodes parwatcodes commented Nov 28, 2019

Resolves #5

  • Added if block which throws an error message if dropStatement is empty.
  • Added test case to cover it.

@codecov-io
Copy link

codecov-io commented Nov 28, 2019

Codecov Report

Merging #28 into master will increase coverage by 1.88%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #28      +/-   ##
=========================================
+ Coverage   21.02%   22.9%   +1.88%     
=========================================
  Files          11      11              
  Lines         176     179       +3     
  Branches       11      11              
=========================================
+ Hits           37      41       +4     
  Misses        137     137              
+ Partials        2       1       -1
Impacted Files Coverage Δ
src/sqlRunner.ts 61.36% <100%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a906799...f7f915a. Read the comment docs.

src/util/ErrorHandler.ts Outdated Show resolved Hide resolved
src/sqlRunner.ts Outdated Show resolved Hide resolved
src/sqlRunner.ts Outdated Show resolved Hide resolved
@mesaugat mesaugat changed the title Fixes misleading logs, will throw an error if object type names doesn't match directory convention Throw an error if object type names doesn't match directory convention Nov 28, 2019
@kabirbaidhya kabirbaidhya merged commit 0debc64 into leapfrogtechnology:master Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Logs are misleading in rollback / teardown stage
4 participants