Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some fixes in example for ts migrations with node & mssql #115

Merged
merged 3 commits into from
Mar 22, 2021
Merged

Some fixes in example for ts migrations with node & mssql #115

merged 3 commits into from
Mar 22, 2021

Conversation

samirsilwal
Copy link
Collaborator

Changes

  • Updated some of the dependencies
  • Some minor fixes & updates in docker files
  • Updated readme
  • tested locally
    Screenshot from 2021-03-22 15-53-08

@samirsilwal samirsilwal self-assigned this Mar 22, 2021
@samirsilwal samirsilwal changed the title Some fixes in example for ts with node Some fixes in example for ts migrations with node & mssql Mar 22, 2021
mesaugat
mesaugat reviewed Mar 22, 2021
View reviewed changes
Copy link
Member

@mesaugat mesaugat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall.

mesaugat
mesaugat approved these changes Mar 22, 2021
View reviewed changes
Copy link
Member

@mesaugat mesaugat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Please merge it when ready.

@samirsilwal @mesaugat
Update examples/node-app-mssql-ts/docker-compose.yml
4d080d8 
Co-authored-by: Saugat Acharya <mesaugat@gmail.com>
@samirsilwal samirsilwal merged commit 3d5b571 into master Mar 22, 2021
@samirsilwal samirsilwal deleted the node-mssql-ts branch March 22, 2021 11:38
@mesaugat mesaugat mentioned this pull request Mar 25, 2021
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mesaugat mesaugat mesaugat approved these changes

@cham11ng cham11ng Awaiting requested review from cham11ng

@aanchal-adk aanchal-adk Awaiting requested review from aanchal-adk

Assignees

@samirsilwal samirsilwal

Labels
example
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samirsilwal @mesaugat